Skip to content

[PWGDQ] Cleanup of unused code - #17262

Merged
iarsene merged 1 commit into
AliceO2Group:masterfrom
axti98:CleanupCode
Aug 3, 2026
Merged

[PWGDQ] Cleanup of unused code#17262
iarsene merged 1 commit into
AliceO2Group:masterfrom
axti98:CleanupCode

Conversation

@axti98

@axti98 axti98 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  1. Deletion of ReducedInfoTablesAlice3.h since it was moved to ALICE3/DataModel
  2. Removed duplication of cut
  3. Removed unused muon references in VertexingAlice3 functions

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 35 errors, ⚠️ 906 warnings, 🔕 91 disabled

@axti98
axti98 marked this pull request as ready for review July 31, 2026 07:43
@alibuild

alibuild commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0664a58 at 2026-08-02 10:00:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 67 errors and 0 warnings.'
Found 67 errors and 0 warnings.
++ [[ 67 -gt 0 ]]
++ cat /sw/BUILD/69a1f8157b8cb55c2e9ee62b4a18175ed6c0d9f3/O2Physics-code-check/errors.txt
PWGDQ/Core/CutsLibrary.cxx:7530:33: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7560:35: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7567:35: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7578:35: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7933:21: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:7977:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.cxx:8008:10: error: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.h:122:23: error: function 'o2::aod::dqcuts::ParseJSONAnalysisCompositeCut' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
PWGDQ/Core/CutsLibrary.h:152:37: error: function 'o2::aod::dqmlcuts::makeLabeledCutsMl' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1205:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1206:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1568:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1572:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1807:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1826:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1882:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1906:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1930:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1956:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1969:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2636:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2772:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2788:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2812:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2858:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2878:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:2936:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3369:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3403:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3431:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3463:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3497:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3551:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3647:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3672:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3947:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:4004:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:4056:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:4115:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:4189:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:4441:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.h:4511:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@iarsene
iarsene merged commit facb270 into AliceO2Group:master Aug 3, 2026
11 of 14 checks passed
@axti98
axti98 deleted the CleanupCode branch August 3, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants